I see many questions posted on StackOverflow and CodeReview asking for tkinter best practices and improvements. While many of the contributions to those questions are interesting, they also teach bad and even harmful coding habits that result in scalability and maintenance issues.
On the present short article, I am mainly going to address the Best way to structure a tkinter application question asked on StackOverflow and review what is good and what is bad in the provided answers.
First of all, do not use a wildcard import as stated in the accepted answer. This is important when you use Tk themed widgets. To be more clear, when you code:
from tkinter import * from ttk import *
This will result in substituting all
tkinter widgets with
ttk ones; but may be you want to use specific
ttk widgets only.
I agree when the accepted answer states that this "makes the code completely obvious when you are using Tkinter classes, ttk classes, or some of your own". However I disagree with the bold text statement because you should not even dare to code a class name as Button for example. Ths is what is written in the famous Clean Code book written by Robert Cecil Martin on page 50: "not to encode the container type into the name."
So the recommanded import is as follows:
import tikter as tk # Python 3.x import Tkinter as Tk # Python 2.x
The main application is a class
While GUI are behind the development of OOP paradigm, there are other non OOP paradigms, such as "functional reactive programming" , to design GUIs. However, they do not have, AFAIK, serious implementations. And since you will not get disappointed by relying on OOP concepts to design a tkinter GUI, I have to reproduce the nicely worded paragraph in the accepted answer to the above linked question: This gives you a private namespace for all of your callbacks and private functions, and just generally makes it easier to organize your code. In a procedural style you have to code top-down, defining functions before using them, etc. With this method you don't since you don't actually create the main window until the very last step. I prefer inheriting from tk.Frame just because I typically start by creating a frame, but it is by no means necessary.
The class initializer
The secret of a beautiful tkinter GUI design lays within the main class' initializer. Thus I give it the full attention. There are few wrong things with the accepted answer however. Especially with the class' initializer:
class MainApplication(tk.Frame): def __init__(self, parent, *args, **kwargs): tk.Frame.__init__(self, parent, *args, **kwargs) self.parent = parent <create the rest of your GUI here>
The first thing I would like to highlight is the number of parameters hold by the initializer: while
**kwargs allow a function to handle a variable number of parameters, this initializer's design must absolutely be avoided because parameters constitute a different level of abstraction from the function’s or class' name. In other words, when you instantiate the "MainApplication()" class, you push the reader of your code (and yourself) to think on different levels of details: while maybe one could understand what your class is doing just from its well chosen name, he will have to think about lower level details which are the arguments1 you have to pass to it. A suitable tkinter class should not be, at worst, monadic.
parent parameter above is also called sometimes
master. I personally prefer to call it
master as there is one master widget by a tkinter application, while any widget can be a parent of an other widget. The accepted answer shows you must code:
self.parent = parent
but it does not explain why. Actually there are are two reasons for that. The first one is common to all situations you may encounter in any programming context in any other programming language: "Don’t use routine parameters as working variables It’s dangerous to use the parameters passed to a routine as working variables. Use local variables instead"2. The second reason for this way of doing things is that it will avoid you later in stumbling in many
AttributeError exception situations.
The second line of code that should come right away after the
self.master = master instruction is a
self.configure_gui() function3 Which only purpose is to save the general settings and configurations of your applications.
For instance, in a typical configuration function you may want to specify the size of the main window of your GUI and disable resizing it and, why not, set a custom title to your application:
def configure_gui(self): self.master.title("Snake game") self.master.geometry("500x500") self.master.resizable(False, False)
The advantage of this approach is that you can decide to change the setting of your application whenever you want, and most importantly, you know where you will have to do it!
An other wrong thing taught by the contributions to that question is teaching to instantiate classes and creating application widgets directly from within the initializer itself. The good practice I recommend is to use a function called
create_widgets() inside which you can create the widgets of your application in case you have very widgets to deal with or, in case you have to design a rich GUI with different components, areas and surfaces, follow a top-down approach by calling other smaller functions each having its own responsibility:
def create_widgets(self): self.create_menu(...) self.create_game_board(...)
Last but not the least, follow the SaYa idiom and never use more than one layout manager for the same containing parent widget.
1 Parameters are the named variables in function signatures, and arguments are the values passed to functions.
2 Steve McConnell, Complete Code, page 176.
3 You can choose a name of your own, but respect the naming conventions specified in PEP8.